Feature: Support strikethrough formatting #17

New Issue

2020-06-06T14:05:33Z

makeworld-the-better-one commented

2020-06-06 14:05:33 +00:00

(Migrated from gitlab.com)

See this question for some escape codes. It'd be nice to have this available as a tag as well.

See [this question](https://askubuntu.com/questions/528928/how-to-do-underline-bold-italic-strikethrough-color-background-and-size-i) for some escape codes. It'd be nice to have this available as a tag as well.

tslocum commented

2020-06-09 22:31:00 +00:00

(Migrated from gitlab.com)

tcell has not yet implemented support for strikethrough. Please help push towards implementing it upstream and it will also be supported in cview by commenting or, if possible, opening a pull request on tcell.

I've implemented support for italic flags just now.

tcell has [not yet implemented support for strikethrough](https://github.com/gdamore/tcell/issues/256). Please help push towards implementing it upstream and it will also be supported in cview by commenting or, if possible, opening a pull request on tcell. I've [implemented support for italic flags](https://gitlab.com/tslocum/cview/-/commit/1d976945dcca30b0105b955bd0bb8414a1629214) just now.

tslocum commented

2020-06-09 22:31:25 +00:00

(Migrated from gitlab.com)

changed title from Feature: Support {-italics and strikethrough-} to Feature: Support {+strikethrough formatting+}

changed title from **Feature: Support {-italics and strikethrough-}** to **Feature: Support {+strikethrough formatting+}**

makeworld-the-better-one commented

2020-06-10 01:14:14 +00:00

(Migrated from gitlab.com)

Thanks!

nahojkap commented

2021-02-05 13:56:31 +00:00

(Migrated from gitlab.com)

@tslocum While you added strikethrough handling in the overlayStyle in utils.go as part of your commit, I think you might have forgotten to update the colorPattern regexp? The [::s] pattern is not recognized unfortunately.

@tslocum While you added strikethrough handling in the overlayStyle in utils.go as part of your commit, I think you might have forgotten to update the `colorPattern` regexp? The [::s] pattern is not recognized unfortunately.

tslocum commented

2021-02-07 04:52:24 +00:00

(Migrated from gitlab.com)

Thanks @nahojkap. I have updated the pattern.

Sign in to join this conversation.