Don't wrap tab bar for TabbedPanels #54

New Issue

tslocum · 2021-02-17T16:32:59Z

makeworld-the-better-one commented

2021-02-17 16:32:59 +00:00

(Migrated from gitlab.com)

When you open a lot of tabs in a TabbedPanels, the tab bar wraps and forms multiple lines. I think it would look better if the tab bar went off screen, and the correct tab came into focus (by scrolling) when you went to that tab.

This is what Amfora v1.7.x does, but the upcoming version that will update cview (currently on the cview-update branch) uses TabbedPanels, which changes the behaviour.

When you open a lot of tabs in a `TabbedPanels`, the tab bar wraps and forms multiple lines. I think it would look better if the tab bar went off screen, and the correct tab came into focus (by scrolling) when you went to that tab. This is what Amfora v1.7.x does, but the upcoming version that will update cview (currently on the `cview-update` branch) uses `TabbedPanels`, which changes the behaviour.

tslocum added the

enhancement

label 2021-05-18 15:56:40 +00:00

tslocum referenced this issue from a commit

2021-05-25 20:09:58 +00:00

Allow specifying TabbedPanels switcher height

tslocum closed this issue

2021-05-25 20:09:58 +00:00

makeworld commented

2021-05-29 19:45:57 +00:00

By removing s.Highlight() in bd144c2430, highlighting the current tab in my application (Amfora) no longer works. Was it a mistake to remove it? Am I right in thinking that that line is why it breaks what I was doing before? If so please re-open the issue.

By removing `s.Highlight()` in bd144c2430499dc834fa1436260b11e6323d77fc, highlighting the current tab in my application (Amfora) no longer works. Was it a mistake to remove it? Am I right in thinking that that line is why it breaks what I was doing before? If so please re-open the issue.

tslocum referenced this issue from a commit

2021-05-30 17:54:07 +00:00

Fix highlighting current TabbedPanels tab

tslocum commented

2021-05-30 17:55:33 +00:00

Thanks, that line was indeed removed by mistake. I've just restored it.