Render images as images instead of links #4

New Issue

f · 2021-06-03T20:32:30Z

f commented

2021-06-03 20:32:30 +00:00

It would be nice if images are rendered as images instead of links. This should be easily done be adding some switch case here:

https://code.rocketnine.space/tslocum/gmitohtml/src/branch/master/pkg/gmitohtml/convert.go#L129-L134

Is there a reason not to do this?

It would be nice if images are rendered as images instead of links. This should be easily done be adding some switch case here: https://code.rocketnine.space/tslocum/gmitohtml/src/branch/master/pkg/gmitohtml/convert.go#L129-L134 Is there a reason not to do this?

f changed title from ~~Render images as images~~ to Render images as images instead of links

2021-06-03 20:32:39 +00:00

tslocum added the

enhancement

label 2021-06-04 01:19:53 +00:00

tslocum commented

2021-06-04 01:21:21 +00:00

I think this would be a nice opt-in feature.

f referenced a pull request that will close this issue

2021-06-08 23:26:43 +00:00

Convert images to images instead of links #5

f commented

2021-06-08 23:28:45 +00:00

Poster

I created a PR for that. But I am not sure what exactly happened here: The binary (iamges) data will be put inside a HTML template. Maybe binary files are note supported yet? If I got some free time, I will dig into it.

tslocum closed this issue

2021-07-10 03:03:20 +00:00

Sign in to join this conversation.