tslocum
/
tinyib
7
8
Fork 2
Code Issues 32 Pull Requests 1 Activity

Use file lock (flock) to prevent concurrency issues #251

New Issue
Closed
opened 2021-09-19 06:37:06 +00:00 by ghost123321 · 5 comments
ghost123321 commented 2021-09-19 06:37:06 +00:00

Even with TINYIB_DELAY set to half a minute, sometimes if when posting you press the 'Submit' button quick twice, the same post will be posted twice, bypassing TINYIB_DELAY.
Saw this happen 3 times to other users already, and happened to myself when posting.

Oh also this allows to upload the same file twice, even if duplicated files are disabled.
I couldn't replicate it on purpose though but will take a screenshot next time it happens.

Even with TINYIB_DELAY set to half a minute, sometimes if when posting you press the 'Submit' button quick twice, the same post will be posted twice, bypassing TINYIB_DELAY. Saw this happen 3 times to other users already, and happened to myself when posting. Oh also this allows to upload the same file twice, even if duplicated files are disabled. I couldn't replicate it on purpose though but will take a screenshot next time it happens.
ghost123321 commented 2021-09-19 06:47:27 +00:00
Poster

Forgot to mention, on flatfile mode.

Forgot to mention, on flatfile mode.
tslocum changed title from TINYIB_DELAY not fully working. to Use file lock (flock) to prevent concurrency issues 2021-09-23 00:04:27 +00:00
tslocum commented 2021-09-23 00:06:15 +00:00
Owner

Flat file really should be avoided when possible. Please use the migration tool to switch to SQLite3 or another database mode if you can.

I'll look into using flock to process incoming posts serially.

Flat file really should be avoided when possible. Please use the migration tool to switch to SQLite3 or another database mode if you can. I'll look into using `flock` to process incoming posts serially.
tslocum added the
bug
 label 2021-09-23 00:06:19 +00:00
ghost123321 commented 2021-09-24 07:58:54 +00:00
Poster

oh but the single thing I liked the most about TinyIB over other ib software is flatfile , should it be avoided for now because of the bugs or avoided always because its only meant to be for testing or whatever?

oh but the single thing I liked the most about TinyIB over other ib software is flatfile , should it be avoided for now because of the bugs or avoided always because its only meant to be for testing or whatever?
tslocum commented 2021-10-06 01:34:57 +00:00
Owner

Until this issue, there weren't any bugs with flat file (as far as I'm aware). I am recommending against flat file here and in the README because it is very slow. This isn't a problem for all sites, but if you want to use a file-based database, SQLite3 is a much better database mode. The included migration tool makes it easy to try different modes.

Until this issue, there weren't any bugs with flat file (as far as I'm aware). I am recommending against flat file here and in the README because it is very slow. This isn't a problem for all sites, but if you want to use a file-based database, SQLite3 is a much better database mode. The included migration tool makes it easy to try different modes.
ghost123321 commented 2021-10-11 06:32:14 +00:00
Poster

oh okay, another question, does the moderation log work for you in flatfile? it dosn't for me

oh okay, another question, does the moderation log work for you in flatfile? it dosn't for me
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
sqlitefix
shortcut
json
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tslocum/tinyib#251
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?