tslocum/tinyib
7
7
Fork 2
Code Issues 32 Pull requests 1 Activity

Fix audit log for flat file database #257

Merged
tslocum merged 1 commit from averageByte/tinyib:fix/flatfile-audit-log into master 2022-06-24 05:29:09 +00:00
Conversation 3 Commits 1 Files changed 1 +4 -4
averageByte commented 2022-06-22 14:21:29 +00:00
Contributor
Copy link

PHP runs out of memory due to flat file's audit log implementation, and manage mode actions break.

Warning: Undefined array key 1 in /tmp/tinyib/inc/database/flatfile.php on line 207

Warning: Undefined array key 2 in /tmp/tinyib/inc/database/flatfile.php on line 208

Warning: Undefined array key 3 in /tmp/tinyib/inc/database/flatfile.php on line 209

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 65011720 bytes) in /tmp/tinyib/inc/database/flatfile/flatfile.php on line 344
PHP runs out of memory due to flat file's audit log implementation, and manage mode actions break. ``` Warning: Undefined array key 1 in /tmp/tinyib/inc/database/flatfile.php on line 207 Warning: Undefined array key 2 in /tmp/tinyib/inc/database/flatfile.php on line 208 Warning: Undefined array key 3 in /tmp/tinyib/inc/database/flatfile.php on line 209 Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 65011720 bytes) in /tmp/tinyib/inc/database/flatfile/flatfile.php on line 344 ```
averageByte commented 2022-06-22 15:16:50 +00:00
Author
Contributor
Copy link

Closes #245

Closes #245
tslocum commented 2022-06-22 22:37:51 +00:00
Owner
Copy link

Nice catch. Please change $log['id'] to $log[LOG_ID], and then I will merge this. Thanks.

Nice catch. Please change `$log['id']` to `$log[LOG_ID]`, and then I will merge this. Thanks.
averageByte force-pushed fix/flatfile-audit-log from 771677564b to f1e527e77e 2022-06-23 05:14:59 +00:00 Compare
averageByte force-pushed fix/flatfile-audit-log from f1e527e77e to c5af7a0ef7 2022-06-23 05:15:45 +00:00 Compare
averageByte commented 2022-06-23 05:16:34 +00:00
Author
Contributor
Copy link

Done.

Done.
tslocum merged commit 648a4fe752 into master 2022-06-24 05:29:09 +00:00
averageByte deleted branch fix/flatfile-audit-log 2022-06-26 13:29:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tslocum/tinyib#257
No description provided.
Delete branch "averageByte/tinyib:fix/flatfile-audit-log"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?