tslocum/twins
1
1
Fork 2
Code Issues 2 Pull requests 1 Releases Activity

Add support for custom CSS files #11

Merged
tslocum merged 4 commits from f/twins:custom-css into master 2021-07-10 02:37:56 +00:00
Conversation 1 Commits 4 Files changed 3 +34
f commented 2021-06-08 20:12:23 +00:00
Contributor
Copy link

Specify the styles config option for a host and point to a
valid CSS file to use this instead of the default one. This fixes #9.

Specify the ```styles``` config option for a host and point to a valid CSS file to use this instead of the default one. This fixes #9.
f added 1 commit 2021-06-08 20:12:24 +00:00 
Specify the ```styles``` config option for a host and point to a
valid CSS file to use this instead of the default one. This fixes #9.
f commented 2021-06-23 11:57:57 +00:00
Author
Contributor
Copy link

Any update on this?

Any update on this?
tslocum requested changes 2021-07-09 05:37:30 +00:00
tslocum left a comment
Owner
Copy link

Thanks for submitting these changes.

Thanks for submitting these changes.
CONFIGURATION.md Outdated
@ -81,6 +81,11 @@ Set this option to `true` to disable this feature.
Pages are converted automatically by [gmitohtml](https://code.rocketnine.space/tslocum/gmitohtml).
## Styles
tslocum commented 2021-07-09 05:32:12 +00:00
Owner
Copy link

Please rename the option to StyleSheet.

Please rename the option to StyleSheet.
f commented 2021-07-09 20:20:49 +00:00
Author
Contributor
Copy link

Renamed it to StyleSheet

Renamed it to ```StyleSheet```
f marked this conversation as resolved
serve_https.go Outdated
@ -34,0 +40,4 @@
return http.StatusNotFound, -1, ""
}
cssBytes, err = ioutil.ReadFile(styleFilepath)
tslocum commented 2021-07-09 05:34:02 +00:00
Owner
Copy link

Please load the custom style sheets during server initialization, so that they only need to be loaded once.

Please do not overwrite cssBytes, as it may be used by hosts which lack a custom style sheet.

Please load the custom style sheets during server initialization, so that they only need to be loaded once. Please do not overwrite cssBytes, as it may be used by hosts which lack a custom style sheet.
f commented 2021-07-09 20:21:31 +00:00
Author
Contributor
Copy link

I've put it in the config.go, which seems the right place to do it.

I've put it in the ```config.go```, which seems the right place to do it.
f marked this conversation as resolved
f added 1 commit 2021-07-09 20:18:03 +00:00 
If there is a custom CSS file specified and usable (it exists and is
readable), we precache it on server startup (for every host). This
increase the request performance and reduce IO-load slightly.
f added 1 commit 2021-07-09 20:20:14 +00:00
f added 1 commit 2021-07-09 20:21:41 +00:00
tslocum merged commit 9cd235c469 into master 2021-07-10 02:37:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
tslocum
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tslocum/twins#11
No description provided.
Delete branch "f/twins:custom-css"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?